Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate y-space fit inputs into two classes #157

Open
GuiMacielPereira opened this issue Jan 10, 2025 · 0 comments · May be fixed by #166
Open

Separate y-space fit inputs into two classes #157

GuiMacielPereira opened this issue Jan 10, 2025 · 0 comments · May be fixed by #166
Assignees
Labels
enhancement New feature or request vesuvio-analysis

Comments

@GuiMacielPereira
Copy link
Collaborator

The current script uses the inputs for the y-space fit for both the forward and backward scattering workspaces.
This means that both backward and forward scattering are sharing the same y-space fit, which does not make much sense.

The class for y-space fit inputs should be split into the forward and backward inputs classes, so that the new analysis_inputs.py file should only contain two classes: one for forward analysis and the other backward analysis

@GuiMacielPereira GuiMacielPereira linked a pull request Jan 17, 2025 that will close this issue
@GuiMacielPereira GuiMacielPereira self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vesuvio-analysis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant