Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change implementation of VesuvioCalculateGammaBackground #75

Closed
GuiMacielPereira opened this issue Dec 7, 2023 · 0 comments · Fixed by #131
Closed

Change implementation of VesuvioCalculateGammaBackground #75

GuiMacielPereira opened this issue Dec 7, 2023 · 0 comments · Fixed by #131
Assignees
@GuiMacielPereira
Labels
enhancement New feature or request vesuvio-package

Comments

@GuiMacielPereira
Copy link
Collaborator

Problem
Older version of code iterated over each spectrum individually to perform the gamma background correction.

Solution
Due to a recent bug fix, we can use the same function to operate on the entire workspace, avoiding a for loop.
@GuiMacielPereira GuiMacielPereira added the enhancement New feature or request label Dec 7, 2023
@GuiMacielPereira GuiMacielPereira self-assigned this Aug 28, 2024
@GuiMacielPereira GuiMacielPereira linked a pull request Aug 28, 2024 that will close this issue
Update gamma correction to use updated algorithm #131
Merged
@GuiMacielPereira GuiMacielPereira moved this to Awaiting Approval in Release 6.11 Vesuvio Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Approval to Done in Release 6.11 Vesuvio Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuiMacielPereira GuiMacielPereira

Labels
enhancement New feature or request vesuvio-package
Projects
No open projects
Release 6.11 Vesuvio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gamma correction to use updated algorithm mantidproject/vesuvio
2 participants
@GuiMacielPereira @MialLewis