Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing a tag from all models, a blank filter remains on reload #3618

Open
Aevaris opened this issue Feb 20, 2025 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Aevaris
Copy link

Aevaris commented Feb 20, 2025

Describe the bug
After removing a tag from all models, that tag is still in the URL and blank on the filter panel.

To Reproduce
Steps to reproduce the behavior:

  1. Click a tag
  2. Select all models and remove that tag

Expected behavior
Clear from the URL and from the GUI to save the user clicks

Screenshots

Image

Image

@Aevaris Aevaris added the bug Something isn't working label Feb 20, 2025
@Floppy
Copy link
Collaborator

Floppy commented Feb 20, 2025

This happens because the tag will have been completely removed, but the filter list doesn't check that the tag exists before applying it. So, we should make it check. Thanks for spotting it!

@Floppy Floppy added the good first issue Good for newcomers label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants