From 0b29501aec4c15656fb3cb8b86d480d55585bee4 Mon Sep 17 00:00:00 2001 From: Tao Peng Date: Wed, 12 Oct 2022 12:27:58 -0700 Subject: [PATCH] CI: install pysocks when building binaries --- .github/workflows/python-package.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 2531b11c7..cd21affcf 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -68,6 +68,9 @@ jobs: # Enable for Python3.8 only because it often fails at codesign (subprocess timeout) if: matrix.platform == 'macos-latest' && startsWith(github.ref, 'refs/tags/') && matrix.python-version == 3.8 run: | + # see https://github.com/mapillary/mapillary_tools/issues/566 + # TODO: move it to extras in setup.py + python3 -m pip install pysocks ./script/build_osx # Could run full integration tests with the binary (it might be slow) pytest tests/integration @@ -76,6 +79,9 @@ jobs: - name: Build and test with Pyinstaller on Ubuntu (Python 3.8 only) if: matrix.platform == 'ubuntu-latest' && startsWith(github.ref, 'refs/tags/') && matrix.python-version == 3.8 run: | + # see https://github.com/mapillary/mapillary_tools/issues/566 + # TODO: move it to extras in setup.py + python3 -m pip install pysocks ./script/build_linux # Could run full integration tests with the binary (it might be slow) pytest tests/integration @@ -84,6 +90,9 @@ jobs: - name: Build and test with Pyinstaller on Windows (Python 3.8 only) if: matrix.platform == 'windows-latest' && startsWith(github.ref, 'refs/tags/') && matrix.python-version == 3.8 run: | + # see https://github.com/mapillary/mapillary_tools/issues/566 + # TODO: move it to extras in setup.py + python3 -m pip install pysocks ./script/build_bootloader.ps1 ./script/build_win.ps1 # Could run full integration tests with the binary (it might be slow)