Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data-driven property specification to line-dasharray #2261

Closed
kboyd-fb opened this issue Mar 9, 2023 · 5 comments
Closed

Add Data-driven property specification to line-dasharray #2261

kboyd-fb opened this issue Mar 9, 2023 · 5 comments
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed

Comments

@kboyd-fb
Copy link

kboyd-fb commented Mar 9, 2023

User Story

As a software engineer I can use feature properties to customize the line-dasharray property on line layers, so that users of my application can have more in depth customization features on their map.

Rationale

  • The types say that this is a data-driven property specification
"line-dasharray"?: PropertyValueSpecification<Array<number>>;

Impact

  • Users that want to customize this property need to add individual layers with different line-dasharray properties, and filter each layer's visible features to those which should show in that style

Any information on if this would be possible, or if there exist any work arounds would be greatly appreciated.

@HarelM
Copy link
Collaborator

HarelM commented Mar 9, 2023

I think this is a good addition.
A small note, the current typings do not suggest that this is a data driven property.
Also note that mapbox code that implemented this is not open in terms of license and we should not copy it.

@HarelM HarelM added enhancement New feature or request PR is more than welcomed Extra attention is needed labels Mar 9, 2023
@DustinBrinkFB
Copy link

+1 This would be useful!

@wipfli
Copy link
Contributor

wipfli commented Mar 28, 2023

If you have not already done it, you can give this bounty direction an upvote: maplibre/maplibre#167

@1ec5
Copy link
Contributor

1ec5 commented Aug 14, 2023

Duplicate of #1235?

@HarelM
Copy link
Collaborator

HarelM commented Aug 14, 2023

Yup. Closing.

@HarelM HarelM closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is more than welcomed Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants