Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a _development snapshot_ release of sssom schema with pydantic instead of regular data classes #337

Open
7 tasks
matentzn opened this issue Nov 16, 2023 · 2 comments
Assignees

Comments

@matentzn
Copy link
Collaborator

As per @cmungall using the pydantic data classes could significantly improve the performance of the sssom tooling. I would like to try the following:

  • Switch to pydantic data classes on a branch
  • Make a candidate release (ensure this creates a development snapshot on pypi, not a regular one)
  • Create a branch in sssom py using that
  • See what breaks (report here)
  • If all ok, create a candidate release of sssom-py
  • Import into oak, see what breaks, report here
  • Make proper releases
@hrshdhgd
Copy link
Contributor

Now the data classes we currently have are source from a YAML file and then Linkml's python generator creates the data class file. Your vision is to replace all that by 1 pydantic data class file, correct? Does this mean cleaning out linkml dependencies?

@matentzn
Copy link
Collaborator Author

Thanks for this question.. I was hoping to be able to pass instances of the pydantic data classes to the linkml converters the same way I was able to pass the old data classes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants