Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to associate labels to ids in repeated slots #344

Open
dr-shorthair opened this issue Jan 16, 2024 · 3 comments
Open

How to associate labels to ids in repeated slots #344

dr-shorthair opened this issue Jan 16, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@dr-shorthair
Copy link

Some properties of Mappings have unrestricted cardinality, and some IDs and matching labels (e.g. author_id+author_label, reviewer_id+reviewer_label).

Is there a convention to associate these correctly?

@matentzn
Copy link
Collaborator

@dr-shorthair Thank you for reaching out!

There is currently no way to associate author_id and author_label - and this is by design. From the early days of SSSOM, we decided that the core design feature of SSSOM is simplicity, which meant, in essence, avoiding a nested data model. There are no nested elements in sssom at all - formally, all elements are associated directly with the mapping. What you would want (and many others like you) is to be able to have, in the datamodel at least, an author element with two slots, id and label. Unfortunately, this is not supported, and won't be in the standard model. There have been debates on a separate more structured model, but so far no one has shown enough interest to spearhead the design of such a model (which could be quite complex).

I personally think of it like this:

We should always use author_id if possible. Only if not possible, use author_label. Managing metadata about people involved in the mapping process should be managed elsewhere (else, why not add "author_expertise" or "author_affiliation" to the metadatamodel?).

In any case, nothing here is clear cut, and I can see a lot of push back against what I am saying :P

@dr-shorthair
Copy link
Author

Thanks. In my original question, I almost commented that *_label should be treated as non-normative, with *_id being the default, but wasn't quite sure how to phrase that.

@gouttegd
Copy link
Contributor

Re-opening because @matentzn ’s answer, about how author_id and author_label (and other similar slots such as creator_id, etc.) are not linked and should not be thought of as being linked, should really be part of the spec. The question in the ticket is a valid one (I have been asking that myself), and the spec should provide an answer to it.

Right now the spec about author_label simply says: “In the spirit of provenance, consider using author_id instead.” That is not enough.

@gouttegd gouttegd reopened this Jul 11, 2024
@gouttegd gouttegd added the documentation Improvements or additions to documentation label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants