fix: resolves Unimplemented type: 3 error for geojson format #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acalcutt
reviewed
Feb 25, 2025
src/serve_data.js
Outdated
| @@ -21,6 +21,7 @@ import { openMbTilesWrapper } from './mbtiles_wrapper.js'; | |||
|
|
|||
| import fs from 'node:fs'; | |||
| import { fileURLToPath } from 'url'; | |||
| import zlib from 'zlib'; | |||
There was a problem hiding this comment.
Is zlib needed here, we are using gunzipP from
import { gunzipP, gzipP } from './promises.js'; , which links that file itslef
There was a problem hiding this comment.
You're right. I removed the duplicate import
acalcutt
reviewed
Feb 26, 2025
src/serve_data.js
Outdated
| data = await gunzipP(data); | ||
| isGzipped = false; | ||
| } | ||
| delete headers['Content-Encoding']; |
There was a problem hiding this comment.
do you think this delete headers['Content-Encoding']; line is needed, won't it just be updated to gzip anyway on line 159
headers['Content-Encoding'] = 'gzip';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were stuck receiving the unimplemented type 3 error when updating to version 5.x. Moved the isGzipped condition outside the tileJSONformat condition and removed content-encoding headers resolves the issue.