Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marfs must be built with a valid configuration but uses a different one at run time. #166

Open
cadejager opened this issue Sep 26, 2016 · 1 comment
Labels

Comments

@cadejager
Copy link
Contributor

Marfs must be build with a valid configuration. However, this configuration is not used at run time as it uses the one set in $MARFSCONFIGRC. Is it possible to remove the need for a configfile at buildtime for marfs?

@jti-lanl
Copy link
Contributor

It would be easy to remove this -- it looks like it's just a step in the libconfig makefile that serves to validate the config, which might be useful because the runtime reporting of configuration-parse problems (in some cases) is terrible. By default, the local build of libconfig just uses marfs_cctest.cfg, which is a "generic" configuration. However, it looks like build_marfs overrides this with $MARFSCONFIG, for the libconfig build. If you don't have MARFSCONFIG set (e.g. a generic build), this will break the libconfig build.

In an effort to keep the build-time parse-test, I tweaked the build_marfs to allow libconfig to fall-back to using marfs_cctest.cfg, if MARFSCONFIG is not defined. Does that resolve the issue, or would you truly rather just suppress the parse-test phase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants