Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename size classes? #52

Open
mnlevy1981 opened this issue Jun 6, 2023 · 3 comments
Open

Rename size classes? #52

mnlevy1981 opened this issue Jun 6, 2023 · 3 comments

Comments

@mnlevy1981
Copy link
Collaborator

Instead of "small", "medium", and "large" (which gets confusing when talking about "Large Pelagic" vs "Foragers") should we use "larval", "juvenile", and "adult"? Open to other suggestions as well, but it would be really nice to drop the "small Large Pelagic" and "large Large Pelagic" terminology.

@cpetrik
Copy link

cpetrik commented Jun 6, 2023 via email

@mnlevy1981
Copy link
Collaborator Author

@cpetrik I think the long names are only used in the diagnostic output. I just noticed that @kristenkrumhardt has a plot titled "Total large large pelagic fish" in her poster, which reminded me that this has come up a few times. It's a bummer that one size class encompasses both larval and juvenile foragers, that definitely adds a layer of difficulty to changing the naming scheme.

@cpetrik
Copy link

cpetrik commented Jun 7, 2023

@mnlevy1981 , for diagnostic names, I would go with: immature forage fish, mature forage fish, larval large pelagic fish, juvenile large pelagic fish, adult large pelagic fish, larval demersal fish, juvenile demersal fish, and adult demersal fish. In the code, there should be 3 size classes (small, medium, large) and two maturity classes (immature, mature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants