Fix IE8 issues #27
Closed
Fix IE8 issues #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (dataAttrs.length > 0) { | ||
| dataAttrs.forEach(function(dataAttr) { | ||
| if (el.getAttribute(dataAttr)) { | ||
| obj[dataAttr] = el.getAttribute(dataAttr); |
There was a problem hiding this comment.
Is this, how vdom wants data-attribs? Does this work? (I assumed it only accepted DOM properties, and setting the name of an attrib as a property doesn't seem to make sense with that assumption in mind...)
There was a problem hiding this comment.
@marcelklehr It seems to work, here is the test case: https://github.com/agentcooper/vdom-virtualize/blob/master/specs/spec/spec.js#L55
|
I found a simpler solution to enable data-* attributes, see #26 |
| return; | ||
| } | ||
|
|
||
| if (el.tagName.toLowerCase() === 'button' && propName === 'type') { |
There was a problem hiding this comment.
Is this really necessary? I notice github has <button type="button">s...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
IMG tag and styles are working correct now.
For data-attributes I've made a manual solution, where you need to provide data attributes you will search for: