Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropoff Locations are Hardcoded #71

Open
BalintFarkas opened this issue Mar 4, 2019 · 1 comment
Open

Dropoff Locations are Hardcoded #71

BalintFarkas opened this issue Mar 4, 2019 · 1 comment
Assignees
Labels
bot Chat bot enhancement New feature or request PWA Progressive Web App

Comments

@BalintFarkas
Copy link
Contributor

Building and floor choices are hardcoded into the chatbot instead of being populated dynamically.

Please see PromptForBuildingStepAsync() and PromptForFloorStepAsync() within ConfirmDropoffDialog.cs.

return await step.PromptAsync( BuildingPromptName, new PromptOptions { Prompt = MessageFactory.Text("In which building did you park the car?"), Choices = new List<Choice> { new Choice("M"), new Choice("S1"), new Choice("GS"), new Choice("HX") }, }, cancellationToken);

var floors = new List<string>(); switch (state.Building) { case "M": floors = new List<string> { "-1", "-2", "-2.5", "-3", "-3.5", "outdoor" }; break; case "S1": floors = new List<string> { "-1", "-2", "-3" }; break; case "GS": floors = new List<string> { "-1", "outdoor" }; break; case "HX": floors = new List<string> { "-3" }; break; }

@BalintFarkas BalintFarkas added the bug Something isn't working label Mar 4, 2019
@mark-szabo mark-szabo added enhancement New feature or request PWA Progressive Web App bot Chat bot and removed bug Something isn't working labels Mar 4, 2019
@mark-szabo
Copy link
Owner

Thanks! 👍
Same for PWA frontend. Should pull details from the .well-known endpoint at startup and store it in a singleton.

@mark-szabo mark-szabo self-assigned this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot Chat bot enhancement New feature or request PWA Progressive Web App
Projects
None yet
Development

No branches or pull requests

2 participants