Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_color validator in plain generator #521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcfadden
Copy link

@mcfadden mcfadden commented Jul 7, 2022

This moves the IS_COLOUR validation out of the text generator and into the ParamValidators module so we can use it in the plain generator as well.

Prior to this, specifying a color in hex format in the plain generator would raise a Dragonfly::ParamValidators::InvalidParameter exception.

Fixes #519 (and maybe #518 too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS style color raising InvalidParameter when using plain generator
1 participant