Skip to content
This repository has been archived by the owner on Aug 26, 2020. It is now read-only.

Migrate schematron implementation to built-in #377

Open
grechaw opened this issue Jun 26, 2018 · 2 comments
Open

Migrate schematron implementation to built-in #377

grechaw opened this issue Jun 26, 2018 · 2 comments
Assignees
Milestone

Comments

@grechaw
Copy link
Contributor

grechaw commented Jun 26, 2018

When built-in schematron validation is available, entity services can take advantage of it by placing a compiled version of entity services sch. schemas in the modules directory.
This could be checked in here to github or in svn directly

@grechaw grechaw self-assigned this Nov 9, 2018
@grechaw
Copy link
Contributor Author

grechaw commented Nov 9, 2018

Since 9.0-8 has reached functionally complete date, this mod should be queued up for work. It's a non-functional change but it would be good to knock it out with some chance to check out regressions

@grechaw grechaw added this to the 9.0-8 milestone Nov 9, 2018
@grechaw
Copy link
Contributor Author

grechaw commented Nov 10, 2018

I've done the initial foray into the switch. It seems like it's working. However the new implementation doesn't report the same failures are the previous one. I'd like to find out how to control the reporting in the new implementation. It might be that we can just modify the keys to be more precise and elicit the more granular error that we're looking for.

As an example of what im talking about -- an entity with missing info notes that there is no primary key -- which while strictly true is not the most relevant validation error for such a descriptor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant