Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing of {min/mean/max}.controls arguments #170

Open
1 of 3 tasks
benthestatistician opened this issue Jun 4, 2019 · 1 comment
Open
1 of 3 tasks

Processing of {min/mean/max}.controls arguments #170

benthestatistician opened this issue Jun 4, 2019 · 1 comment

Comments

@benthestatistician
Copy link
Collaborator

findSubproblems() drops at least some empty or infeasible subproblems. When it's invoked in fullmatch.matrix(), in a situation where the user has provided a vector min.controls argument:

  • we need to trim the min.controls vector to match the length of the subproblem list. (And similarly for mean.controls, max.controls, omit.fraction.)

  • We also need to ensure alignment of these arguments with subproblems. (I think; perhaps it's already being done in some cases. But I couldn't see where.)

  • We need unit tests of this input-checking, for future proofing.

@benthestatistician
Copy link
Collaborator Author

314eee7 addresses the first part and at least some of the second. Remains to do testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant