Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchfailed() tests, documentation #172

Open
3 tasks
benthestatistician opened this issue Jun 8, 2019 · 0 comments
Open
3 tasks

matchfailed() tests, documentation #172

benthestatistician opened this issue Jun 8, 2019 · 0 comments

Comments

@benthestatistician
Copy link
Collaborator

I experienced an issue where matchfailed() returned NA for a small number of observations, breaking a script. (Unfortunately I couldn't stop to investigate.) Hypothesis: this is how it records an exact matching category with no treatments or controls, such that it wouldn't make sense to try to make matches within it.

  • Whether that's correct or not should be recorded in the Roxygen block describing the function, and there should be tests to confirm the behavior.
  • Accompanying that should be a few simple tests to confirm thatmatchfailed() does indeed mark subclasses in which matching failed, and doesn't mark those in which it succeeded.
  • The person who does this should also test any other scenarios occurring to them where the function might unexpectedly return an NA as opposed to a TRUE or FALSE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant