Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo how to use matched.distances() in vignettes #185

Open
benthestatistician opened this issue Mar 2, 2020 · 1 comment
Open

Demo how to use matched.distances() in vignettes #185

benthestatistician opened this issue Mar 2, 2020 · 1 comment

Comments

@benthestatistician
Copy link
Collaborator

There should be a passage of a vignette explaining how to use matched.distances() to calculate the sum or mean of matched distances. One use of this is to determine matched distances along the distances used for matching; another is to determine matched distances along a different distance.

@benthestatistician
Copy link
Collaborator Author

Notes:

  • It calls for e.g. sum( unlist( matched.distances(mymatch, mydist) ) ), which has at least 2 nonintuitive aspects (the need to pass a distance; unlist()).
  • One natural place for this passage is in or after the "Distances" subsection of fullmatch-vignette.Rmd.

benthestatistician added a commit that referenced this issue Mar 2, 2020
We were recommending the use of `summary.optmatch()`
to assemble matched distance info, but as of this writing
it doesn't do that, and the subsection is internally incoherent
(promises matched distance information that the command we present
does not return). We may reenable that when addressing #173,
at which time we should consider reverting this commit.

If on the other hand we resolve #173 without restoring
sum-of-matched-distances information to the output of
`summary.optmatch()`, then it becomes more important to add
vignette material explaining how to use `matched.distances()`
to extract this info.  Cf. #185.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant