Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance.Rmd #241

Open
nullsatz opened this issue Nov 19, 2024 · 4 comments
Open

performance.Rmd #241

nullsatz opened this issue Nov 19, 2024 · 4 comments

Comments

@nullsatz
Copy link
Collaborator

pkgdown is failing and complaining about the lack of a bookdown package while trying to process performance.Rmd even though performance.Rmd is added to .Rbuildignore

@benthestatistician
Copy link
Collaborator

Based on what @josherrickson wrote over here on the propertee site wiki, I suspect there's an adjustment to ./pkgdown.yml that has to happen in order to keep it from trying to build performance.Rmd and post it to the pkgdown site.

@josherrickson
Copy link
Collaborator

Do we want the performance vignette on the website? If so, we just need to tweak the building script in .github/workflows/pkgdown.yaml.

If not, let's adopt a similar file structure to propertee, creating a 'developer_docs' folder that is Rbuildignore'd and not included in the site either.

@benthestatistician
Copy link
Collaborator

All else equal, I'd say post it to the website. I.e. please tweak. If it turns out to be more tweaking than was bargained for, no problem to revert to the developer_docs/ solution.

@josherrickson
Copy link
Collaborator

Looking closer - @nullsatz was the choice of bookdown::html_document2 instead of rmarkdown::html_document a deliberate choice? if not, switching to rmarkdown::html_document should be the easiest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants