Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change xdebug trigger method to improve performance #1230

Open
danstaver opened this issue Oct 3, 2024 · 0 comments
Open

Change xdebug trigger method to improve performance #1230

danstaver opened this issue Oct 3, 2024 · 0 comments

Comments

@danstaver
Copy link
Contributor

Description
Today, you have to manually enable/disable xdebug, which is taking time, and sometime the user can forget to enable it and wonders why the breakpoint didnt trigger, or, you have the option to always have it enabled, which is negatively affecting performance in local.

It would be great if we could have the same logic in place as what today adobe commerce cloud has, where, even in production i can trigger xdebug, without it affecting regular users
https://experienceleague.adobe.com/en/docs/commerce-cloud-service/user-guide/develop/test/debug#debug-for-pro-staging-and-production
image
What we could try to do, implement something similar to comment #2 from
magento/magento-cloud-docker#112 (comment)

Steps To Reproduce

  1. N/A

Expected Result

  • xdebug triggers only when XDEBUG_SESSION cookie present in request. This request is being sent to a separate process with loaded and configured xdebug extension
  • if XDEBUG_SESSION cookie not present, request is sent to a process which does not have xdebug loaded at all

Actual Result
xdebug is either enabled or disabled (but, even if enabled or disabled, the extension is still loaded)

@danstaver danstaver changed the title Change xdebug Change xdebug trigger method to improve performance Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant