Error handling on storage loss - aka. disable housekeeping on stateloss

[danir-de]

Hey there,
I've been trying out what happens to this module on a partial or total storage loss.
In my testing, the data dir /opt/nextcloud-data is located on a different, network attached storage.

When simulating an outage on said external storage server by turning it off, the fstab mount of course get's wanky.

What's interesting in that is what happens when the puppet client tries to make a run during said outage:
Puppet gets stuck on fact checking and (since the datadir with the current puppet-nextcloud status information is missing) assumes that nextcloud is not installed - and then triggers a complete reinstall.

It would be great to implement a stop command which completely skips the complete install/update and housekeeping process if the state files are missing - something like: skip_on_stateless => true, so that the installation doesn't nuke itself, should storage become available again.

Edit: I know install_enabled can be set to false, but this doesn't completely disables the module module in an error state - also it stops you from using the upgrade functionality, when there is no stateloss.