Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Intro" chords category ? #1211

Open
MercierCorentin opened this issue May 30, 2024 · 1 comment
Open

New "Intro" chords category ? #1211

MercierCorentin opened this issue May 30, 2024 · 1 comment

Comments

@MercierCorentin
Copy link

MercierCorentin commented May 30, 2024

Some chords shouldn't be placed on top of the text, like the ones below, because it would disrupt the formatting created by the author.

In the data I receive, these are indicated as chords but also specified not to be part of the song. Therefore, I wrapped them with [...] to make them look like annotations.

[Interlude]
[|(G) | G | Em | Em |]
[| C  | C | D  | D |]

The problem is that when I transpose in real time, I retrieve all elements with the .chord class to then transpose the chord and inject the new chord in JavaScript. So the wrapped chords are not transposed. This results in an inconsistent rendered chordSheet.

Did I handle this incorrectly, or do we need a new type of chord, for example, .chord-no-tab, to achieve what I want ?

Thanks again for the great work !

@aonghas
Copy link

aonghas commented Oct 7, 2024

You can get around this by escaping the chords and annotations individually, ie.

[Interlude]
[| (][G][) | ][G][ | ][Em][ | ][Em][ |]
[| ][C][  | ][C][ | ][D][  | ][D][ |]

Then the chords will also be transposed.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants