Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make keyboard shortcuts more discoverable #250

Closed
matatk opened this issue Jan 15, 2019 · 0 comments
Closed

Make keyboard shortcuts more discoverable #250

matatk opened this issue Jan 15, 2019 · 0 comments
Assignees
@matatk
Labels
bug
Milestone
2.5.x

Comments

@matatk
Copy link
Owner

matatk commented Jan 15, 2019 •
edited
Loading

As pointed out by a recent Mozilla Add-ons review—can add a link to the new help page to the pop-up/sidebar.

This was planned for after #238, in 2.6.0, but given it is a bit of an omission, especially on Firefox (the extent of which hadn't occurred to me), it seems best to add it ASAP.

Thanks for your feedback and suggestion :-).
@matatk matatk added the bug label Jan 15, 2019
@matatk matatk added this to the 2.5.x milestone Jan 15, 2019
@matatk matatk self-assigned this Jan 15, 2019
@matatk matatk mentioned this issue Jan 18, 2019
Merged
matatk added a commit that referenced this issue Jan 18, 2019
@matatk
fix(UI): Add help and preferences links to GUIs (#253)
da628f9 
This makes Help and Preferences more discoverable. It involved renaming some messages for clarity, factoring out translation and also improving the styles somewhat, including having slight differences on the sidebar styles (to make it fill height). The links don't show up in the DevTools panel.

When the stand-alone options page is done, there should be a big refactoring and harmonisation of styles across options, GUIs and help.

Fixes #250.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matatk matatk

Labels
bug
Projects
None yet
Milestone
2.5.x
Development

No branches or pull requests
1 participant
@matatk