Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement/Accessibility]: Consider using button with SASS mixin for card-action #565

Open
3 tasks done
Tracked by #543
gselderslaghs opened this issue Dec 26, 2024 · 0 comments
Open
3 tasks done
Tracked by #543

Comments

@gselderslaghs
Copy link
Member

Before submitting...

Context

This issue is a follow up of #543 (#81)

Proposal:
Replace Cards action links with buttons because we could optimally use the existing global buttons styling and it would comply with Material M3 standards

Here is a Codepen example where we have links (current setup) in their actions section and a comparison with buttons (enhancement regarding to M3 guidelines and accessibility)
I needed to add additional btn class but if we consider implementing the buttons styling as a mixin on top of the current CSS classes we could avoid adding additional classes and implement it in the SCSS setup, as a result no documentation update would be required and it would be backwards compatible, users can define additional button styles as shown in the 3rd example

Current Behavior

The cards actions include basic a html element links

Expected behavior

From the Material M3 standards we could enhance this functionality with adding buttons instead of basic html links

Possible Solutions or Causes

Replace Cards action links with buttons in SCSS setup, migrate basic button styling class to SCSS mixin and apply it to the HTML a elements inside card-action wrapper

Your Environment

  • Version used: v2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant