Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some operations return str, but there are proper response models #44

Open
csadorf opened this issue Aug 25, 2022 · 0 comments · May be fixed by #45
Open

Some operations return str, but there are proper response models #44

csadorf opened this issue Aug 25, 2022 · 0 comments · May be fixed by #45
Assignees

Comments

@csadorf
Copy link
Collaborator

csadorf commented Aug 25, 2022

I noticed that we are returning str on a few operations, e.g., here:

@check_capability_availability
def create_collection(
self,
collection_name: object_storage.CollectionName = None,
metadata: dict = None,
) -> str:
return self._client.put(
self._proxy_path("createCollection"),
params={"collection_name": collection_name} if collection_name else {},
headers=_encode_metadata(metadata),
).text

However, according to the API, the response is actually also a JSON object. Can we fix that inconsistency, please?

Originally posted by @csadorf in #43 (review)

@csadorf csadorf linked a pull request Aug 25, 2022 that will close this issue
@singhpranjali singhpranjali self-assigned this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants