Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve failed perturbations handling in elastic workflow #817

Open
gpetretto opened this issue Apr 24, 2024 · 1 comment
Open

Improve failed perturbations handling in elastic workflow #817

gpetretto opened this issue Apr 24, 2024 · 1 comment

Comments

@gpetretto
Copy link
Contributor

gpetretto commented Apr 24, 2024

I have seen a few cases where some pertubations of the elastic workflow fail and the elastic tensor is still calculated since on_missing_references is set to NONE. Due to the fact that sym_reduce is True by default, the number of perturbations is already relatively small for highly symmetric systems. So, the result, although still somewhat reasonable, was wrong.
I think there are a few points that could be addressed to improve the current situation:

  • there should probably be an option to disable this behaviour, since it may lead to wrong results. Especially if symmetry is used to reduce the number of perturbations.
  • maybe a check should be performed in the fit_elastic_tensor and raise an error if too many perturbations have failed or, in a more advanced fashion, if all the perturbations concering one kind of strain failed.
  • If I am not mistaken, in case of failure of some of the perturbations, there is no obvious way of knowing that it happened just from the output database. It may be good to have a warning flag in the document or a list of the deformations that were supposed to be in the list of perturbations, but were not calculated. While this information could be retrieved from fireworks/jobflow_remote, it seems quite inconvenient and is not a given that the information will still be easily available at a later time.

What do you think? Did anybody else have these kind of issues?

@JaGeo
Copy link
Member

JaGeo commented Apr 27, 2024

Even though, I have build a force-field based elastic maker, I haven't tested it yet in so much detail but I think we should make it as safe as possible for users. Warnings and additional information on the fit should be available to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants