Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREE.Scene: .dispose() has been removed. #695

Open
JoshDLane opened this issue May 11, 2023 · 4 comments
Open

THREE.Scene: .dispose() has been removed. #695

JoshDLane opened this issue May 11, 2023 · 4 comments

Comments

@JoshDLane
Copy link

Trying to use the CrystalToolkitScene component in react. Coming across this error:
Screenshot 2023-05-10 at 10 47 58 PM

I also see there is an error in the storybooks for the CrystalToolkitScene component Cannot read properties of undefined (reading 'rotation').

Is there a version of this library where this component is stable that i should rollback too? or any other recommendations on how to get it working?

@yang-ruoxi
Copy link
Member

Hi @JoshDLane, thanks for opening the issue. Which version are you using?

@JoshDLane
Copy link
Author

Using:
"@materialsproject/mp-react-components": "^0.3.0-SNAPSHOT.1683931142",
"react": "^18.2.0",
"react-dom": "^18.2.0"

its the same issue for the last few mp-react-components for as far as ive checked (0.1.12, 0.1.10)

The issue is resolved when i change back to using ReactDOM.render (react 17) instead of ReactDOM.createRoot

@JoshDLane
Copy link
Author

another note @yang-ruoxi :
I am using vite (https://vitejs.dev/guide/) in this project.

when i am trying to use this npm package in vanilla create react app I get this error below unless I use the exact react version I see used in mp-react-components (16.14). I get this error for all components, not just CrystalToolkitScene.

Screenshot 2023-05-17 at 1 36 02 PM

@yang-ruoxi
Copy link
Member

thanks for the feedback! I'm not the original developer of this repo but will try to look into it as best as I can - maybe @codytodonnell has a better idea of the potential cause of this error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants