Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of objects does not revert to original color after hover interaction concluded #697

Open
mkhorton opened this issue Jul 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mkhorton
Copy link
Member

Creating this issue to track.

Bug likely somewhere in mouseMoveListener.

Anecdotally, seems to occur more often with larger scenes / smaller viewports, or rapid mouse movements.

Resolutions could be:

  • Fixing underlying bug, e.g. ensuring all objects returned to original color when hover interaction concluded.
  • Simply removing the change in color, e.g. this line.

Suggestion to review Three.js docs for recommended way to implement this feature.

@mkhorton mkhorton added the bug Something isn't working label Jul 28, 2023
@mkhorton
Copy link
Member Author

Adding a note that this is the first time I've looked at this code in a while, it looks like it needs a bit of a tidy up as well. There are some half-implemented features there related to animation support that should either be linked to issues (to be fully implemented at a later date) or removed in the interests of having a cleaner code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant