You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DiffusionAnalyzer will fail if there is no framework ions (namely if all ions are mobile)
Basically if framework_indices is an empty list. The first dimension of framework_disp would be 0. Then drift would be a matrix filled with NAN, which leads to failure in the downstream.
This should a minor bug that is easy to fix.
The text was updated successfully, but these errors were encountered:
Can you put in a fix with a unittest and submit a PR? I think it is relatively simple to test if framework_indices: and then set the drift and displacement.
pymatgen-analysis-diffusion/pymatgen/analysis/diffusion/analyzer.py
Lines 229 to 243 in 5923fb5
DiffusionAnalyzer will fail if there is no framework ions (namely if all ions are mobile)
Basically if
framework_indices
is an empty list. The first dimension offramework_disp
would be 0. Thendrift
would be a matrix filled with NAN, which leads to failure in the downstream.This should a minor bug that is easy to fix.
The text was updated successfully, but these errors were encountered: