Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the constructors uniform! #189

Open
luca-heltai opened this issue Oct 31, 2015 · 1 comment
Open

Make the constructors uniform! #189

luca-heltai opened this issue Oct 31, 2015 · 1 comment

Comments

@luca-heltai
Copy link
Contributor

Our constructors, derived from ParameterAcceptor, all take default values. Some of them take as default values the strings representing the values, some of them take as default values the actual values.

We should be consistent. Taking the strings makes one passage easier, but it increases the number of member variables for no reasons (the default value should be stored in the variable itself).

@luca-heltai
Copy link
Contributor Author

Taking the strings makes one passage easier

This is no longer true. We should really remove all unneded strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant