Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker Angular 13 support #45

Open
vpetrusevici opened this issue Nov 6, 2021 · 8 comments
Open

Datepicker Angular 13 support #45

vpetrusevici opened this issue Nov 6, 2021 · 8 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@vpetrusevici
Copy link

Hi, DatePicker currently doesn't work with Angular 13. I tried to create a PR to fix it but looks like I need your help to finish it.
#44

@vpetrusevici vpetrusevici changed the title Angular 13 support Datepicker Angular 13 support Nov 7, 2021
@vpetrusevici
Copy link
Author

@matheo I'm sorry to bother you. Are you still support this lib?

@vpetrusevici
Copy link
Author

I created an updated package with support Angular 13 and luxon 2 https://www.npmjs.com/package/@vpetrusevici/datepicker

@matheo
Copy link
Owner

matheo commented Nov 30, 2021

Thanks for this @vpetrusevici
I will be upgrading this repo in the next few days creating the 11.x and 12.x branches in the process

@matheo matheo added the dependencies Pull requests that update a dependency file label Nov 30, 2021
@matheo matheo self-assigned this Dec 5, 2021
@jbistis
Copy link

jbistis commented Jan 6, 2022

Does DatePicker work with Angular 13 yet? It is not correctly rendering.
datepicker issue

@jbistis
Copy link

jbistis commented Jan 9, 2022

@matheo, are there plans to support angular 13?

@tutkli
Copy link

tutkli commented Feb 10, 2022

Version 13.0.0-beta.1 still renders incorrectly with Angular 13

@matheo
Copy link
Owner

matheo commented Feb 10, 2022

Have you guys configured the styles with the new SASS modules?
https://github.com/matheo/angular/tree/master/libs/datepicker#angular-12

@tutkli
Copy link

tutkli commented Feb 11, 2022

Have you guys configured the styles with the new SASS modules? https://github.com/matheo/angular/tree/master/libs/datepicker#angular-12

Hello, @matheo , this worked perfectly, thank you for answering.
Just a thing. stylePreprocessorOptions configuration in angular.json goes under "options"

"projects": {
  "[your-project]": {
    "architect": {
      "build": {
        ...
       "options": {
         ...
         "stylePreprocessorOptions": {
           "includePaths": ["node_modules"]
         }
       }
      }
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants