Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT prune default value different between celer_path and Lasso #269

Open
cruyffturn opened this issue Jun 30, 2022 · 1 comment
Open

Comments

@cruyffturn
Copy link

Thank you again for this remarkably fast library.

In the celer_path the default value of prune is 0 while in Lasso, MultiTaskLasso, and GroupLasso it's set to 1 (True).

@cruyffturn cruyffturn changed the title Minor Comment, prune default value different between celer_path and Lasso MAINT prune default value different between celer_path and Lasso Jun 30, 2022
@mathurinm
Copy link
Owner

Thanks for pointing this ! It would be better to harmonize indeed. Can you send a PR to harmonize celer_path (set prune default value to True there) and eventually in other functions (Multitask case) ?
You can also add an entry in the whatsnew to let users know this has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants