Evalue triggers to commit transactions in miner

[manav2401]

In miner, there are mainly 2 paths which triggers block production.

One is the ideal way which gets triggered when a new block is received

bor/miner/worker.go

Line 538 in fd71beb

case head := <-w.chainHeadCh:

Another is when there are new transactions

bor/miner/worker.go

Line 623 in fd71beb

case ev := <-w.txsCh:

The second one makes sense in case of ethereum when there's plenty of time to build a block and there are better transactions available. I don't think it makes sense for us as we should not be very picky in 2s block time because it can lead to delays in block execution, db operations and block propagation.

We should evaluate whether we need this trigger to enable mining or not.

Secondly, if we choose to keep it, the logic doesn't honour commit interrupt as we don't set any context with timeout before commit transactions. We should add it in that case or try to generalise commit interrupt so that it can handle both case.

[cffls]

Makes sense. Curious to see if the second case is ever triggered in bor.

[manav2401]

It did in the sentry (posdevnodes-mainnet-2) I was debugging today and hence I created a task for it.

[manav2401]

Addressed in #1434