Adds test for phpcs using Matomo coding standards, #PG-3751

[AltamashShaikh]

Description:

Adds test for phpcs using Matomo coding standards
Fixes: #PG-3751

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[snake14]

Looking really good 👍 The only concern I have is the code sniffer dependency (vendor/) being committed. That doesn't seem like something that should be included in production.

[AltamashShaikh]

Looking really good 👍 The only concern I have is the code sniffer dependency (vendor/) being committed. That doesn't seem like something that should be included in production.

@snake14 Slevomat requires phpcodensiffer

[snake14]

@snake14 Slevomat requires phpcodensiffer

@AltamashShaikh Shouldn't Slevomat be require-dev too?

[AltamashShaikh]

@snake14 As discussed I gitignored all those libraries

[snake14]

@snake14 As discussed I gitignored all those libraries

Thank you. That looks a lot better. You could probably ignore the two new files in vendor/bin/ as well, but it's not a big deal.

[AltamashShaikh]

@snake14 As discussed I gitignored all those libraries

Thank you. That looks a lot better. You could probably ignore the two new files in vendor/bin/ as well, but it's not a big deal.

@snake14 Done :)

[michalkleiner]

I think it would be great to split this PR into two - one where we add the config and any necessary dependencies, and leave the reformatting for a separate one. Together it makes it harder to review.

[snake14]

Aside from Michal's latest comments, I think things are looking good 👍

[AltamashShaikh]

@sgiehl @michalkleiner Can you guys please check this PR ? If all looks good we can add the similar changes to other plugins.

[sgiehl]

I think that looks fine now. 👍