Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: create release tags for downstream packaging #363

Open
SuperSandro2000 opened this issue Mar 21, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@SuperSandro2000
Copy link

Is your feature request related to a problem? Please describe.
I can't easily download a specific version from GitHub without searching through the commit history.

Describe the solution you'd like
Tag release versions.

Describe alternatives you've considered
Searching through the commit history which is not ideal.

Additional context

@SuperSandro2000 SuperSandro2000 added the enhancement New feature or request label Mar 21, 2021
@DanielGoldfarb
Copy link
Collaborator

Sandro,

I understand that tags will make it easier to examine the code for a particular version, and it is definitely on my list of things to do, however it is not a high priority for me right now, compared to other changes we are trying to get done (and relative to how often we find the need to go back and examine the code for a particular version.

In the meantime I would suggest the following method for viewing the code corresponding to a particular version:

  1. Examine release versions with release dates here: https://pypi.org/project/mplfinance/#history
  2. Examine the PR history here: https://github.com/matplotlib/mplfinance/pulls?q=is%3Apr+is%3Aclosed
  3. Find the latest PR that could have gone into the version you want. Let's say we are interested in version 0.12.7a5 which was released on 23-Jan-2021. From the PR history page we see the latest PR that could have gone into that version is PR #321
  4. CLick on that PR and notice just above where it says "Pull request successfully merged" it will indicate the merge commit with a phrase something like: "... merged commit c036d31 into matplotlib:master on Jan 23" (If you want, you can also click on that commit number to verify that the version_info variable changed to the version you want.)
  5. Create a new branch with that version. For example:
    ~/code/mplfinance$ git checkout -b v0.12.7a5 c036d31
    
    Switched to a new branch 'v0.12.7a5'

HTH. All the best. --Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants