Add support for message avatars #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
requested changes
Jan 11, 2021
| @@ -36,8 +37,10 @@ class Message extends React.Component { | |||
| } | |||
| try { | |||
| const profile = await this.context.client.getProfile(this.props.event.sender); | |||
| const avatarUrl = profile.avatar_url && this.context.client.thumbnailLink(profile.avatar_url, 'scale', 48, 48); | |||
There was a problem hiding this comment.
Bleh, this actually will be bad if we call /profile for every message rendered. Sure we cache, but on first render the cache will be empty so we'll spam the server for the same profile. We should probably add an in-flight cache on Client.getProfile so we return the same HTTP promise for the same user, so we can at least guarantee only 1 HTTP hit per user (currently it's 1:1 based on the number of messages).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
I'm not overly happy with the styling on this one because it feels like the avatars are a bit to one side, however I grew impatient with CSS and moved onto other things.
Timeline
Highlighted