Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sentry reporting further #3306

Open
S7evinK opened this issue Jan 18, 2024 · 0 comments
Open

Update Sentry reporting further #3306

S7evinK opened this issue Jan 18, 2024 · 0 comments
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@S7evinK
Copy link
Contributor

S7evinK commented Jan 18, 2024

#3305 made reporting errors a bit better, but there are still places in the code where we CaptureException in go routines, possibly still sending garbage to Sentry.
For reference: https://docs.sentry.io/platforms/go/usage/concurrency/

It may also make sense to check if we even should report said errors to sentry, as e.g. we should always be able json.Unmarshal things we sent to JetStream ourselves.
@S7evinK S7evinK added good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jan 18, 2024
@S7evinK S7evinK mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Want to help with Dendrite? These are the issues to start with! T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@S7evinK