Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hookshot doesn't verify it's devices #1001

Open
Twi1ightSparkle opened this issue Dec 11, 2024 · 5 comments
Open

Hookshot doesn't verify it's devices #1001

Twi1ightSparkle opened this issue Dec 11, 2024 · 5 comments
Labels
E2EE Encryption related issues S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Refactoring, enabling or disabling functionality, other engineering tasks.

Comments

@Twi1ightSparkle
Copy link
Contributor

Twi1ightSparkle commented Dec 11, 2024

This generates red warning on all it's encrypted messages

screenshot_2024-12-11T14-19-15Z

screenshot_2024-12-11T14-19-41Z

And E2EE Hookshot will stop working entirely once MSC4153: Exclude non-cross-signed devices gets implemented.

@Twi1ightSparkle Twi1ightSparkle changed the title Hookshot doesn't verify it's sessions Hookshot doesn't verify it's devices Dec 11, 2024
@Half-Shot
Copy link
Contributor

This requires https://github.com/element-hq/matrix-bot-sdk/, and the rust sdk bindings to support cross signing. This work isn't trivial, so I'll ask about it.

@szymczag
Copy link

Thanks, @Twi1ightSparkle, for bringing that up — I was just about to create a new issue for this.

Hello, @Half-Shot, is there any chance you could get this fixed in the near future?

@Half-Shot
Copy link
Contributor

Hey hey, this is currently being looked at in element-hq/element-meta#2709

@szymczag
Copy link

@Half-Shot thanks! I can see that the work is in progress, so I'll keep my fingers crossed and wait patiently ;)

@Half-Shot
Copy link
Contributor

I aim to not keep your fingers crossed for too long then :)

@Half-Shot Half-Shot added T-Task Refactoring, enabling or disabling functionality, other engineering tasks. S-Major Severely degrades major functionality or product features, with no satisfactory workaround E2EE Encryption related issues labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2EE Encryption related issues S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Refactoring, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

3 participants