Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwedging doesn't work if wedged session is new, and first one created for device #3427

Open
Tracked by #245
uhoreg opened this issue May 17, 2024 · 3 comments
Open
Tracked by #245

Comments

@uhoreg
Copy link
Member

uhoreg commented May 17, 2024

If

  • Alice sends an encrypted to-device message to Bob
  • Bob doesn't have any existing Olm sessions with Alice
  • the to-device message cannot be decrypted

then Bob will try to mark the Alice as wedged, but AFAICT, SessionManager.mark_device_as_wedged won't do anything because it tries to mark a session with Alice as wedged, but there are no existing sessions stored, so nothing can be marked as wedged.

@uhoreg uhoreg changed the title unwedging doesn't work if wedged session is first one created for device Unwedging doesn't work if wedged session is first one created for device May 17, 2024
@richvdh richvdh changed the title Unwedging doesn't work if wedged session is first one created for device Unwedging doesn't work if wedged session is new, and first one created for device May 22, 2024
@richvdh
Copy link
Member

richvdh commented May 22, 2024

element-hq/element-meta#2389 will touch this code so that would be a good time to fix it.

@richvdh
Copy link
Member

richvdh commented Sep 12, 2024

Annoyingly, we did element-hq/element-meta#2389 and seem to have forgotten about this.

@richvdh
Copy link
Member

richvdh commented Sep 12, 2024

This compounds element-hq/element-meta#2356: if the sender claims a forgotten one-time key, they will keep sending messages using the broken Olm session until the recipient starts a new Olm session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants