Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Room preview should try to update the local data #4729

Open
ganfra opened this issue Feb 27, 2025 · 2 comments
Open

[Task] Room preview should try to update the local data #4729

ganfra opened this issue Feb 27, 2025 · 2 comments
Assignees

Comments

@ganfra
Copy link
Contributor

ganfra commented Feb 27, 2025

Currently, using the room preview api for room we already know, like those with invited or knocked states, is waiting for the server to return, because we want to ensure the data is accurate.
Could be nice to return the local data right away, but still try to fetch data from server, and save this updated data in the store.

@bnjbvr
Copy link
Member

bnjbvr commented Feb 27, 2025

It's a nice idea, but how would that work?

  • The caller knows the information may be outdated, and may call again later?
  • The caller provides a callback that's called when the server response has been received?
  • or something else you had in mind?

@mxandreas
Copy link

It's a nice idea, but how would that work?

My understanding was that we refresh the data anyway when the preview is opened. We just would not block opening the preview because of that. Just my 2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants