Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-server API does not describe what it means for a PDU to be valid #1044

Closed
DMRobertson opened this issue May 4, 2022 · 3 comments · Fixed by #1045
Closed

Server-server API does not describe what it means for a PDU to be valid #1044

DMRobertson opened this issue May 4, 2022 · 3 comments · Fixed by #1045
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented May 4, 2022 •
edited
Loading

Whenever a server receives an event from a remote server, the receiving server must ensure that the event:

  1. Is a valid event, otherwise it is dropped.
  2. ...

Link to problem area: https://spec.matrix.org/unstable/server-server-api/#checks-performed-on-receipt-of-a-pdu

Issue
Presumably "valid" means

  • contains a room_id key
  • the format of the event complies with the Event PDU Format in that room's room version.
@DMRobertson DMRobertson added the clarification An area where the expected behaviour is understood, but the spec could do with being more explicit label May 4, 2022
@DMRobertson
Copy link
Contributor Author

This just narrows the problem to "what does it mean to comply with a PDU format?".

What happens if an event comes in with some other top-level key that's not specified by the room version format? I would guess that we ought to ignore such an event; but I don't know if that's the intent of the spec or the existing practice.

@DMRobertson DMRobertson mentioned this issue May 4, 2022
Merged
@richvdh
Copy link
Member

richvdh commented May 4, 2022

I think this is the same as #365?

@DMRobertson
Copy link
Contributor Author

I think this is the same as #365?

Very much so. Thanks, I should have searched.

@DMRobertson DMRobertson mentioned this issue May 4, 2022
Open
turt2live added a commit that referenced this issue May 10, 2022
@DMRobertson @turt2live
Attempt to define a valid event (#1045)
9ede29a 
* Attempt to define a valid event

Resolves #1044.

Well, maybe.

* Changelog

* link to /rooms, thanks Travis

Co-authored-by: Travis Ralston <[email protected]>

Co-authored-by: Travis Ralston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to define a valid event
2 participants
@richvdh @DMRobertson