Historical spec artifacts starting with v1.11 have broken CSS

[turt2live]

Link to problem area: spec-historical of https://github.com/matrix-org/matrix-spec/releases/tag/v1.11

Issue

compared to:

Expected behaviour
Implied above.

[zecakeh]

As I said in the Matrix Spec & Docs Authoring room, this should be fixed once we handle #1957.

[zecakeh]

I just realized that the issue was in the spec-historical artifact, but not the spec artifact. That is due to the fact that we do not use the same version of Hugo for both. It is due to a big breaking change in Hugo 0.123.0.

The last time that it was updated, only the version for the historical artifact was changed, which was probably not the intended goal. In any case we should probably use a CI variable to make sure that they stay in sync.

[zecakeh]

This brought even more issues, as reported in the matrix-spec room:

FYI, the link to the CORS section in the info box here (https://spec.matrix.org/v1.11/client-server-api/#well-known-uri) is broken. It points to https://spec.matrix.org/v1.11/#web-browser-clients instead of https://spec.matrix.org/v1.11/client-server-api/#web-browser-clients (note the missing client-server-api).

And this is probably not the only broken link, I noticed others when working on #1984. An easy way to find them is to let htmltest do its job. They should all be fragments, so removing the /v1.11/ should fix them.

We could have noticed that sooner if the historical build was also tested with htmltest.

[zecakeh]

And the v1.12 spec-historical artifact has the same issues, since it was built in the same conditions.

Edit: An easy way to fix the v1.11 and v1.12 spec-historical artifacts with no manual work required is to regenerate them with Hugo 0.117.0, like the non-historical artifacts.

[zecakeh]

FWIW I regenerated them locally with hugo 0.117.0, and I checked that the only difference they have with the non-historical spec is the historical info box:

spec-historical-v1.11.tar.gz
spec-historical-v1.12.tar.gz

[turt2live]

as expected, this broke v1.13's release when shipping v1.12 too.