s3_media_upload non-AWS

[HarHarLinks]

The s3_media_upload script suffers from a handful shortcomings that stem from - in contrast to the s3_storage_provider.py module - not inheriting the homeserver config.

Especially the trouble is that the default boto3 client instantiation somehow gets the region (from .aws/config default s3 maybe?) but not the complete URL/domain part - i.e. if you use something other that AWS, synapse will respect that but the upload script won't.

My suggestion is to instead of creating a custom database.yaml config file, to just read the homeserver.yaml instead (or worse, copy all relevant fields into it's own config).
Then parse everything relevant, e.g. endpoint_url to this:

synapse-s3-storage-provider/scripts/s3_media_upload

Line 435 in a38b15b

s3 = boto3.client("s3")

[richvdh]

Especially the trouble is that the default boto3 client instantiation somehow gets the region (from .aws/config default s3 maybe?) but not the complete URL/domain part - i.e. if you use something other that AWS, synapse will respect that but the upload script won't.

this sounds like a duplicate of #25.