From 7a264848780309a5621af57b7832411d97aa40f1 Mon Sep 17 00:00:00 2001
From: fborello-lambda <federicoborello@lambdaclass.com>
Date: Mon, 5 Aug 2024 15:03:01 -0300
Subject: [PATCH] refactor: only ask the rpc if everything fails

---
 store/zksync/tokens.ts | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/store/zksync/tokens.ts b/store/zksync/tokens.ts
index 89190913..8104e7eb 100644
--- a/store/zksync/tokens.ts
+++ b/store/zksync/tokens.ts
@@ -60,16 +60,16 @@ export const useZkSyncTokensStore = defineStore("zkSyncTokens", () => {
       };
     }
 
-    const btL1Address = await provider.getBaseTokenContractAddress();
-    if (btL1Address !== utils.ETH_ADDRESS) {
-      const l1Rpc = useNetworkStore();
-      const l1Provider = new ethers.providers.JsonRpcProvider(l1Rpc.l1Network?.rpcUrls.default.http[0]);
-      const walletEthers = ethers.Wallet.createRandom();
-      const connectedWallet = walletEthers.connect(l1Provider);
-      const ERC20_L1 = new ethers.Contract(btL1Address, IERC20, connectedWallet);
-      const ERC20_SYMBOL: string = (await ERC20_L1.symbol()) || "BT";
-      const ERC20_DECIMALS = (await ERC20_L1.decimals()) || 18;
-      if (!baseToken) {
+    if (!baseToken) {
+      const btL1Address = await provider.getBaseTokenContractAddress();
+      if (btL1Address !== utils.ETH_ADDRESS) {
+        const l1Rpc = useNetworkStore();
+        const l1Provider = new ethers.providers.JsonRpcProvider(l1Rpc.l1Network?.rpcUrls.default.http[0]);
+        const walletEthers = ethers.Wallet.createRandom();
+        const connectedWallet = walletEthers.connect(l1Provider);
+        const ERC20_L1 = new ethers.Contract(btL1Address, IERC20, connectedWallet);
+        const ERC20_SYMBOL: string = (await ERC20_L1.symbol()) || "BT";
+        const ERC20_DECIMALS = (await ERC20_L1.decimals()) || 18;
         baseToken = {
           address: L2_BASE_TOKEN_ADDRESS,
           l1Address: btL1Address,
@@ -78,13 +78,11 @@ export const useZkSyncTokensStore = defineStore("zkSyncTokens", () => {
           decimals: ERC20_DECIMALS,
           iconUrl: "/img/era.svg",
         };
+      } else {
+        baseToken = ethToken;
       }
     }
 
-    if (!baseToken) {
-      baseToken = ethToken;
-    }
-
     const tokens = explorerTokens.length ? explorerTokens : configTokens;
     let nonBaseOrEthExplorerTokens: Token[] = [];
     if (tokens) {