Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Github Token passthrough on terraform #809

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Jan 28, 2025

Summary

Resolving this issue:

Error: Invalid reference from destroy provisioner

  on .terraform/modules/eks/aws/eks-customer/remove-utility.tf line 16, in resource "null_resource" "remove-utilities":
  16:     environment = {
  17:       GIT_REPO_PATH     = self.triggers.gitops_repo_path
  18:       GIT_REPO_URL      = self.triggers.gitops_repo_url
  19:       GIT_REPO_USERNAME = self.triggers.gitops_repo_username
  20:       GIT_REPO_EMAIL    = self.triggers.gitops_repo_email
  21:       GITHUB_TOKEN      = data.github_app_token.this.token
  22:       CLUSTER_NAME      = self.triggers.cluster_name
  23:       ENV               = self.triggers.environment
  24:     }

Destroy-time provisioners and their connection configurations may only
reference attributes of the related resource, via 'self', 'count.index', or
'each.key'.

References to other resources during the destroy phase can cause dependency
cycles and interact poorly with create_before_destroy.

Ticket Link

Release Note

NONE

@toninis toninis requested a review from a team as a code owner January 28, 2025 12:03
@stafot stafot merged commit 116d1f7 into master Jan 28, 2025
1 check passed
@stafot stafot deleted the fix/fix-github-token-passthrough branch January 28, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants