-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Consider renaming interpret()
to createService()
#165
Comments
Personally I'd rather get rid of services altogether. I just haven't figured out how yet :) |
Until you figure out how, can I do this rename in a Pull Request? :) (Including updating the docs!) |
@matthewp ping :) |
@matthewp QQ: Can you elaborate on your wish to drop services completely? (i.e., are you talking about something like |
Yeah, thanks for calling that out @ehuelsmann. I don't think a rename accomplishes anything, so I'm going to close. |
I was proposing a simple name-change (and docs update) to make robot easier to learn. You are discussing (what sounds like) a major rewrite of a big part of the project. I don't see why one had to block the other. But it's been years since I opened this. Glad to see some activity picking up on the project again, though. Whatever the rewrite turns out to be, I hope to check it out as soon as it lands! 👍 |
I understand what you mean. But changing a name is a breaking change. If we haven't figured out services by the time 2.0 is released maybe we can consider it. |
The
interpret()
function returns something called a service everywhere else in the docs.When I was first trying to learn Robot to use in a project of mine, it took me a couple of re-reads for this to sink in. That’s because the other functions return things that match the function name:
createMachine()
returns a machine,transition()
returns a transition,state()
returns a state, and so on.(I don’t normally feel comfortable requesting a change to an API name. However, since Robot is still at version 0.2.x, I suppose this is the appropriate time (before v1.x) to do so.)
Consider renaming
interpret()
tocreateService()
. This would make the function match what we call the thing it returns.It would also make the only 2 top-level functions in Robot start with “create…”. That would be a nice cue that both functions are at that level.
The text was updated successfully, but these errors were encountered: