Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong flags in exported dds #22

Closed
matyalatte opened this issue May 19, 2024 · 1 comment
Closed

Wrong flags in exported dds #22

matyalatte opened this issue May 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@matyalatte
Copy link
Owner

matyalatte commented May 19, 2024

I got two warnings when importing dds in GIMP.

dds_flags_warning

It uses DDSD_PITCH when it should use DDSD_LINEARSIZE.
And it uses DDSD_LINEARSIZE when it should use DDSD_PITCH.

dds.py says

class DDS_FLAGS(IntEnum):
    PITCH = 0x8  # Use "w * h * bpp" for pitch_or_linear_size
    LINEARSIZE = 0x80000  # Use "w * bpp" for pitch_or_linear_size

but it should be

class DDS_FLAGS(IntEnum):
    PITCH = 0x8  # Use "w * bpp" for pitch_or_linear_size
    LINEARSIZE = 0x80000  # Use "w * h * bpp" for pitch_or_linear_size

Most of dds libraries don't care the flags but this should be fixed.

@matyalatte matyalatte added the bug Something isn't working label May 19, 2024
@matyalatte
Copy link
Owner Author

matyalatte commented Jun 18, 2024

Fixed with #23.
I'll close this issue with v0.4.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant