Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno #1364

Open
tmokmss opened this issue Jul 29, 2024 · 9 comments
Open

Add Deno #1364

tmokmss opened this issue Jul 29, 2024 · 9 comments

Comments

@tmokmss
Copy link

tmokmss commented Jul 29, 2024

It appears Deno can sometimes be faster than Node.js or Bun. https://deno.com/blog/aws-lambda-coldstart-benchmarks

It'd be great if this benchmark add Deno runtime.

@gitblit
Copy link

gitblit commented Aug 6, 2024

I agree. I came here looking to see if there was an open request to confirm the claim. Would be great to see this datapoint amongst the other JS runtimes and at varying lambda size - which is something not considered by blog post.

@soundstep
Copy link

soundstep commented Sep 6, 2024

Having a go at it
#1467

@soundstep
Copy link

Hi @maxday (sorry to ping directly), any chance someone can have a look at that one?
#1467
Cheers.

@markhaslam
Copy link

If helpful for implementing this I just noticed that Deno archived the deno-lambda repo (https://github.com/denoland/deno-lambda) just today, and then point to their official documentation on how to deploy Deno to AWS Lambda here: https://docs.deno.com/runtime/tutorials/aws_lambda/

@soundstep
Copy link

soundstep commented Sep 12, 2024

Cheers, I closed that PR and I'll check what that all means.

@vicary
Copy link

vicary commented Sep 12, 2024

@soundstep Out of curiosity I tried to build a lambda myself following the official docs and was greeted with the error The image manifest or layer media type for the source image... on all combinations of build arch and runtime arch, would love to see how you do it!

EDIT: It's OT, edited in place to reduce noise.

I am using docker BuildKit (formerly buildx) so I have to include --provenance=false to prevent said error during Lambda deployement.

@soundstep
Copy link

Without context, I'm not sure, I don't think I've seen that error; I only built a docker image locally on a MacBook Pro M1, and chose the corresponding arm arch, which worked. I still have an issue that needs sorting but that should be fine.

The easiest is probably to build your image on a github action runner and push it from there?

@soundstep
Copy link

FYI, new PR: #1492

@maxday
Copy link
Owner

maxday commented Sep 23, 2024

Thanks a lot! Will take a look at it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants