[Feature] Use client inteface or Psr Client interface

[aedart]

Hi

In your \maxh\Nominatim\Nominatim constructor, you accept a custom Guzzle Client instance, which is really fine. But would it perhaps not be prudent to accept \GuzzleHttp\ClientInterface or \Psr\Http\Client\ClientInterface as argument?
If so, the your component's flexibility will increase, by allowing developers to provide custom http client implementations.

This feature request can be considered somewhat breaking. So, if you accept it, then it should be for your next major version.

[maxhelias]

Hi @aedart,

Indeed, this could be great.
We can event avoid breaking something by blocking Guzzle versions below 7.0 since \Guzzlient\Client implement \Psr\Http\Client\ClientInterface.

It's been a while since I worked on this project, here is some other idea that could be done :

• Remove this statement :

  php-nominatim/src/Nominatim.php

  Lines 103 to 115 in 2706684

  	} elseif ($http_client instanceof Client) {
  	$application_url_client = (string) $http_client->getConfig('base_uri');
  	if (empty($application_url_client)) {
  	throw new NominatimException('http_client must have a configured base_uri.');
  	}
  	if ($application_url_client !== $application_url) {
  	throw new NominatimException('http_client parameter hasn\'t the same url application.');
  	}
  	} else {
  	throw new NominatimException('http_client parameter must be a \\GuzzleHttp\\Client object or empty');
  	}

• Rework the $application_url param on the \maxh\Nominatim\Nominatim class because the base_uri is enough

[aedart]

Hi @maxhelias

That would be great.

As for you additional idea to remove $application_url juggling; I think you are right, it could simplify the constructor logic. However, that will become a breaking change, if your code adheres to semver 2. (You can always release a new major version - its all good for me).