Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay mod bindings and access to mouse/keyboard #957

Open
WSSDude opened this issue Jul 31, 2024 · 2 comments
Open

Overlay mod bindings and access to mouse/keyboard #957

WSSDude opened this issue Jul 31, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@WSSDude
Copy link
Collaborator

WSSDude commented Jul 31, 2024

We disallowed access to keyboard and mouse functions from our fork of sol_ImGui.

I believe, considering ImGui is completely inaccessible from outside of onDraw now, we could reenable keyboard and mouse access to it.

There were few valid requests for such access, like having an ability to have some copy-paste functionality or custom shortcuts while overlay is active.

I would propose reenabling the disabled functions (believe they are just left commented out inside sol_ImGui) and potentially tweaking VKBindings to allow for modbinds separate from in-game ones which would get triggered while overlay to allow for overlay-specific shortcuts.

This could be split into two separate tasks/PRs.

I believe sol_ImGui alone should cover most use-cases, but would need to get properly tested and implemented.

Making the issue so someone can pick it up when they want to. This enhancment would be something that should now be safe and I believe not that hard to implement. Marking it as an enhamcement and good first issue, as I believe it should be quite a small change, at least for the sol_ImGui part.

@WSSDude WSSDude added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2024
@WSSDude
Copy link
Collaborator Author

WSSDude commented Jul 31, 2024

If anyone is willing to pick this up, can provide help as this is something I majorily worked on for CET in the past, know the systems and expected behaviors.

Feel free to contact me.

@WSSDude
Copy link
Collaborator Author

WSSDude commented Jul 31, 2024

Interesting commit for this task:
4f23722

Everything that was removed by this commit that was under SOL_IMGUI_ENABLE_INPUT_FUNCTIONS should get reverted and retested it is

  • only accessible from onDraw
  • works as expected

I suspect 0 to none issues from such partial revert and removal of the define, just dont revert whole commit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant