Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced failure with anyhow #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

replaced failure with anyhow #8

wants to merge 2 commits into from

Conversation

aniketfuryrocks
Copy link

@aniketfuryrocks aniketfuryrocks commented Jan 24, 2022 •
edited
Loading

Fixes #2

@maxjoehnk
Copy link
Owner

Apparently I didn't send my response before.
I would like to have a proper error type here, probably based on thiserror.
The introduction of failure was just so that I could get started faster.

@aniketfuryrocks
Copy link
Author

thiserror works great out of the box with anyhow. Currently the failure library is introducing friction in the usage of this library. Therefore it would be very helpful if you merge this pull request. thiserror can be implemented on top of it easily.

@maxjoehnk
Copy link
Owner

I've implemented the custom error type with thiserror in the branch feature/error-enum. Maybe you can give it a try and report whether this fixes your issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0036: failure is officially deprecated/unmaintained
2 participants
@aniketfuryrocks @maxjoehnk